Add clean stopping with CTRL+C #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The module only deals with line editing, not process control. Whether or not the process should terminate upon closing the readline interface is a caller concern and not something the module should have an opinion on. As an example, take a look at the |
|
Nice. Thanks. Perhaps it would be good to mention this in the readme for isolated use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raw mode, CTRL+C, which typically generates a SIGINT (interrupt signal) to terminate a process, will not function as it normally does. The raw mode is defined by that:
rl.input.setMode(tty.constants.MODE_RAW)I would therefore suggest to add
process.stop()for both CTRL+C and CTRL+DCould be a Windows problem but does including it would not harm other OS.
Best